Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

removed properties from score spec #41

Merged
merged 2 commits into from
Jul 18, 2023
Merged

removed properties from score spec #41

merged 2 commits into from
Jul 18, 2023

Conversation

sujaya-sys
Copy link
Contributor

Description

We are planning to deprecate resource properties in the Score spec: score-spec/spec#61

What does this PR do?

It removes resource properties from the example score.yaml files we store in this repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

ghen

This comment was marked as duplicate.

Sign in to view

ghen
ghen suggested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI code needs to be updated. Otherwise these examples won't work and that would confuse the users.

Please wait for code changes before approving/merging these changes.

@rachfop rachfop mentioned this pull request Jun 6, 2023
Merged
1 task
@ghen
Removed resources properties from Score spec
b00dc79 
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
@ghen
Copy link
Contributor

ghen commented Jul 12, 2023

Ready for the code review.

chrishumanitec
chrishumanitec approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghen ghen merged commit 58c6598 into main Jul 18, 2023
3 checks passed
@ghen ghen deleted the update-examples branch July 18, 2023 08:52
Noordsestern pushed a commit to Noordsestern/score-humanitec that referenced this pull request Aug 30, 2023
@sujaya-sys @Noordsestern
Removed resources properties definitions from Score spec (score-spec#41)
1b817a3 
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
Signed-off-by: Markus Stahl <markus.stahl@humanitec.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ghen ghen ghen requested changes

@chrishumanitec chrishumanitec chrishumanitec approved these changes

@rachfop rachfop rachfop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sujaya-sys @ghen @chrishumanitec @rachfop